From 9cfe5676bc4ccf02654f4dffd0056ea671941409 Mon Sep 17 00:00:00 2001
From: Bangara Raju Kottedi <bangararaju.kottedi@gmail.com>
Date: Tue, 30 Apr 2024 23:58:32 +0530
Subject: [PATCH] code refactoring

---
 PortBlog.API/Controllers/CvController.cs |  4 +-
 PortBlog.API/Models/CvDto.cs             | 73 ++++++++++++++++++++++++
 PortBlog.API/Models/ResumeDto.cs         | 52 -----------------
 PortBlog.API/Profiles/ResumeProfile.cs   |  1 +
 4 files changed, 76 insertions(+), 54 deletions(-)
 create mode 100644 PortBlog.API/Models/CvDto.cs

diff --git a/PortBlog.API/Controllers/CvController.cs b/PortBlog.API/Controllers/CvController.cs
index cc03ced..1fa1e01 100644
--- a/PortBlog.API/Controllers/CvController.cs
+++ b/PortBlog.API/Controllers/CvController.cs
@@ -44,7 +44,7 @@ namespace PortBlog.API.Controllers
         [ProducesResponseType(StatusCodes.Status400BadRequest)]
         [ProducesResponseType(StatusCodes.Status500InternalServerError)]
         [ProducesResponseType(StatusCodes.Status200OK)]
-        public async Task<ActionResult<ResumeDto>> Get(int candidateId)
+        public async Task<ActionResult<CvDto>> Get(int candidateId)
         {
             try
             {
@@ -56,7 +56,7 @@ namespace PortBlog.API.Controllers
 
                 var latestResumeForCandidate = await _resumeRepository.GetLatestResumeForCandidateAsync(candidateId, true);
 
-                return Ok(_mapper.Map<ResumeDto>(latestResumeForCandidate));
+                return Ok(_mapper.Map<CvDto>(latestResumeForCandidate));
 
             }
             catch (Exception ex)
diff --git a/PortBlog.API/Models/CvDto.cs b/PortBlog.API/Models/CvDto.cs
new file mode 100644
index 0000000..57a467c
--- /dev/null
+++ b/PortBlog.API/Models/CvDto.cs
@@ -0,0 +1,73 @@
+namespace PortBlog.API.Models
+{
+    /// <summary>
+    /// CV details of the candidate
+    /// </summary>
+    public class CvDto
+    {
+        /// <summary>
+        /// The id of the cv
+        /// </summary>
+        public int ResumeId { get; set; }
+        /// <summary>
+        /// The title of the candidate
+        /// </summary>
+        public string Title { get; set; } = string.Empty;
+        /// <summary>
+        /// A brief description about the candidate
+        /// </summary>
+        public string About { get; set; } = string.Empty;
+        /// <summary>
+        /// Candidate's information
+        /// </summary>
+        public CandidateDto? Candidate { get; set; }
+        /// <summary>
+        /// Candidate's Social Media links
+        /// </summary>
+        public SocialLinksDto? SocialLinks { get; set; }
+        /// <summary>
+        /// Candidate's blog posts
+        /// </summary>
+        public ICollection<PostDto> Posts
+        {
+            get
+            {
+                return SocialLinks?.Posts ?? new List<PostDto>();
+            }
+        }
+        /// <summary>
+        /// The education details of the candidate
+        /// </summary>
+        public ICollection<AcademicDto> Academics { get; set; } = new List<AcademicDto>();
+        /// <summary>
+        /// The skills of the candidate
+        /// </summary>
+        public ICollection<SkillDto> Skills { get; set; } = new List<SkillDto>();
+        /// <summary>
+        /// The work experiences of the candidate
+        /// </summary>
+        public ICollection<ExperienceDto> Experiences { get; set; } = new List<ExperienceDto>();
+        /// <summary>
+        /// The certifications done by the candidate
+        /// </summary>
+        public ICollection<CertificationDto> Certifications { get; set; } = new List<CertificationDto>();
+        /// <summary>
+        /// The hobbies of the candidate
+        /// </summary>
+        public ICollection<HobbyDto> Hobbies { get; set; } = new List<HobbyDto>();
+        /// <summary>
+        /// The projects of the candidate
+        /// </summary>
+        public ICollection<ProjectDto> Projects { get; set; } = new List<ProjectDto>();
+        /// <summary>
+        /// The project categories of all the projects
+        /// </summary>
+        public ICollection<string> ProjectsCategories
+        {
+            get
+            {
+                return Projects.Select(p => p.Category).Distinct().ToList();
+            }
+        }
+    }
+}
diff --git a/PortBlog.API/Models/ResumeDto.cs b/PortBlog.API/Models/ResumeDto.cs
index 173f40e..ab84532 100644
--- a/PortBlog.API/Models/ResumeDto.cs
+++ b/PortBlog.API/Models/ResumeDto.cs
@@ -5,36 +5,6 @@
     /// </summary>
     public class ResumeDto
     {
-        /// <summary>
-        /// The id of the cv
-        /// </summary>
-        public int ResumeId { get; set; }
-        /// <summary>
-        /// The title of the candidate
-        /// </summary>
-        public string Title { get; set; } = string.Empty;
-        /// <summary>
-        /// A brief description about the candidate
-        /// </summary>
-        public string About { get; set; } = string.Empty;
-        /// <summary>
-        /// Candidate's information
-        /// </summary>
-        public CandidateDto? Candidate { get; set; }
-        /// <summary>
-        /// Candidate's Social Media links
-        /// </summary>
-        public SocialLinksDto? SocialLinks { get; set; }
-        /// <summary>
-        /// Candidate's blog posts
-        /// </summary>
-        public ICollection<PostDto> Posts
-        {
-            get
-            {
-                return SocialLinks?.Posts ?? new List<PostDto>();
-            }
-        }
         /// <summary>
         /// The education details of the candidate
         /// </summary>
@@ -47,27 +17,5 @@
         /// The work experiences of the candidate
         /// </summary>
         public ICollection<ExperienceDto> Experiences { get; set; } = new List<ExperienceDto>();
-        /// <summary>
-        /// The certifications done by the candidate
-        /// </summary>
-        public ICollection<CertificationDto> Certifications { get; set; } = new List<CertificationDto>();
-        /// <summary>
-        /// The hobbies of the candidate
-        /// </summary>
-        public ICollection<HobbyDto> Hobbies { get; set; } = new List<HobbyDto>();
-        /// <summary>
-        /// The projects of the candidate
-        /// </summary>
-        public ICollection<ProjectDto> Projects { get; set; } = new List<ProjectDto>();
-        /// <summary>
-        /// The project categories of all the projects
-        /// </summary>
-        public ICollection<string> ProjectsCategories 
-        { 
-            get 
-            {
-                return Projects.Select(p => p.Category).Distinct().ToList();
-            } 
-        }
     }
 }
diff --git a/PortBlog.API/Profiles/ResumeProfile.cs b/PortBlog.API/Profiles/ResumeProfile.cs
index 8841e13..31ad2a3 100644
--- a/PortBlog.API/Profiles/ResumeProfile.cs
+++ b/PortBlog.API/Profiles/ResumeProfile.cs
@@ -60,6 +60,7 @@ namespace PortBlog.API.Profiles
                     dest => dest.Posts,
                     src => src.MapFrom(src => src.Blog != null ? src.Blog.Posts : new List<Post>())
                 );
+            CreateMap<Resume, CvDto>();
             CreateMap<Resume, ResumeDto>();
             CreateMap<Resume, AboutDto>();
             CreateMap<Resume, CandidateSocialLinksDto>();