rajukottedi/PortBlog.API
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'Improve error handling and logging for mail and OTP endpoints' (#7) from feature/portfolio-admin-auth into dev

Browse Source 
Reviewed-on: #7
This commit is contained in:
rajukottedi 2026-02-16 11:54:21 +05:30
commit 62fc6c1a49
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PortBlog.API/Controllers/AuthController.cs
View File

@ -59,7 +59,7 @@ namespace PortBlog.API.Controllers
catch (Exception ex)
{
logger.LogCritical(ex, "Exception while sending OTP for {ToEmail}.", messageSendDto.ToEmail);
return StatusCode(500, "A problem happened while handling your request.");
return StatusCode(500, ex.Message);
}
}

4
PortBlog.API/Controllers/CvController.cs
View File

@ -262,8 +262,8 @@ namespace PortBlog.API.Controllers
}
catch (Exception ex)
{
_logger.LogCritical($"Exception while sending message from {message.Name}.", ex);
return StatusCode(500, "A problem happened while handling your request.");
_logger.LogCritical(ex, "Exception while sending message from {Name}.", message.Name);
return StatusCode(500, ex.Message);
}
}
}

6
PortBlog.API/Services/MailService.cs
View File

@ -67,14 +67,14 @@ namespace PortBlog.API.Services
}
catch (Exception ex)
{
// Log full exception and persist failed message. Do not rethrow to avoid causing a 500 from OTP generation
// Log full exception and persist failed message.
logger.LogCritical(ex, "Exception while sending mail from {FromEmail} ({Name}).", messageSendDto.FromEmail, messageSendDto.Name);
messageSendDto.SentStatus = (int)MailConstants.MailStatus.Failed;
mailRepository.AddMessage(messageEntity);
await mailRepository.SaveChangesAsync();
// swallow the exception so OTP generation continues; caller can inspect delivery status via message logs
return;
// Throw a descriptive exception so callers can return an error message to the client.
throw new InvalidOperationException($"Failed to send email to '{messageSendDto.ToEmail}'. See inner exception for details.", ex);
}
}
}